patchii/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
forgejo/models/issues
History
oliverpool 0fc61c8836 [BUG] split code conversations in diff tab (#2306) 
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 12:16:11 +00:00
..
assignees.go Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (#28220) 2023-12-07 15:27:36 +08:00
assignees_test.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
comment.go Dont load Review if Comment is CommentTypeReviewRequest (#28551) 2024-02-14 21:44:25 +01:00
comment_code.go [BUG] split code conversations in diff tab (#2306) 2024-02-16 12:16:11 +00:00
comment_list.go Dont load Review if Comment is CommentTypeReviewRequest (#28551) 2024-02-14 21:44:25 +01:00
comment_test.go [BUG] split code conversations in diff tab (#2306) 2024-02-16 12:16:11 +00:00
content_history.go Fix comment permissions (#28213) 2023-11-25 17:21:21 +00:00
content_history_test.go Fix comment permissions (#28213) 2023-11-25 17:21:21 +00:00
dependency.go
dependency_test.go
issue.go [FEAT] allow setting the update date on issues and comments 2024-02-05 14:44:33 +01:00
issue_index.go [GITEA] avoid superfluous synchronized pull_request run when opening a PR (#2236) 2024-02-05 16:57:58 +01:00
issue_index_test.go [GITEA] avoid superfluous synchronized pull_request run when opening a PR (#2236) 2024-02-05 16:57:58 +01:00
issue_label.go
issue_label_test.go
issue_list.go
issue_list_test.go
issue_lock.go
issue_project.go
issue_search.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
issue_stats.go
issue_test.go [MODERATION] User blocking 2024-02-05 15:56:45 +01:00
issue_update.go [MODERATION] User blocking 2024-02-05 15:56:45 +01:00
issue_user.go Add combined index for issue_user.uid and issue_id (#28080) 2023-12-14 09:26:59 +00:00
issue_user_test.go
issue_watch.go
issue_watch_test.go
issue_xref.go [CLEANUP] make golangci-lint@v1.56.1 happy 2024-02-15 16:19:36 +01:00
issue_xref_test.go
label.go Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
label_test.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
main_test.go
milestone.go [FEAT] allow setting the update date on issues and comments 2024-02-05 14:44:33 +01:00
milestone_list.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
milestone_test.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
pull.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
pull_list.go [GITEA] avoid superfluous synchronized pull_request run when opening a PR (#2236) 2024-02-05 16:57:58 +01:00
pull_test.go [GITEA] avoid superfluous synchronized pull_request run when opening a PR (#2236) 2024-02-05 16:57:58 +01:00
reaction.go [MODERATION] User blocking 2024-02-05 15:56:45 +01:00
reaction_test.go [MODERATION] User blocking 2024-02-05 15:56:45 +01:00
review.go Dont load Review if Comment is CommentTypeReviewRequest (#28551) 2024-02-14 21:44:25 +01:00
review_list.go [CLEANUP] make golangci-lint@v1.56.1 happy 2024-02-15 16:19:36 +01:00
review_test.go Fix 500 when deleting a dismissed review (#27903) 2023-11-05 13:25:40 +00:00
stopwatch.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
stopwatch_test.go
tracked_time.go Add ability to see open and closed issues at the same time (#28757) 2024-01-15 15:07:22 +00:00
tracked_time_test.go Add ability to see open and closed issues at the same time (#28757) 2024-01-15 15:07:22 +00:00