patchii/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
forgejo/modules/git
History
zeripath bbffcc3aec
Multiple Escaping Improvements (#17551) 
There are multiple places where Gitea does not properly escape URLs that it is building and there are multiple places where it builds urls when there is already a simpler function available to use this.
    
This is an extensive PR attempting to fix these issues.

1. The first commit in this PR looks through all href, src and links in the Gitea codebase and has attempted to catch all the places where there is potentially incomplete escaping.
2. Whilst doing this we will prefer to use functions that create URLs over recreating them by hand.
3. All uses of strings should be directly escaped - even if they are not currently expected to contain escaping characters. The main benefit to doing this will be that we can consider relaxing the constraints on user names and reponames in future. 
4. The next commit looks at escaping in the wiki and re-considers the urls that are used there. Using the improved escaping here wiki files containing '/'. (This implementation will currently still place all of the wiki files the root directory of the repo but this would not be difficult to change.)
5. The title generation in feeds is now properly escaped.
6. EscapePound is no longer needed - urls should be PathEscaped / QueryEscaped as necessary but then re-escaped with Escape when creating html with locales Signed-off-by: Andrew Thornton <art27@cantab.net>

Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-11-16 18:18:25 +00:00
..
pipeline Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tests/repos Ignore Sync errors on pipes when doing CheckAttributeReader.CheckPath, fix the hang of git cat-file (#17096) 2021-09-20 20:46:51 +01:00
batch_reader.go Add caller to cat-file batch calls (#17082) 2021-09-17 20:54:15 -04:00
blame.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
blame_test.go refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
blob.go Read expected buffer size (#17409) 2021-10-24 22:12:43 +01:00
blob_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
blob_nogogit.go refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
blob_test.go refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
command.go Add proxy settings and support for migration and webhook (#16704) 2021-08-18 21:10:39 +08:00
command_test.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
commit.go Replace list.List with slices (#16311) 2021-08-09 14:08:51 -04:00
commit_convert_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
commit_info.go
commit_info_gogit.go Defer Last Commit Info (#16467) 2021-10-08 15:08:22 +02:00
commit_info_nogogit.go Defer Last Commit Info (#16467) 2021-10-08 15:08:22 +02:00
commit_info_test.go Make commit info cancelable (#16032) 2021-06-06 19:44:58 -04:00
commit_reader.go Tagger can be empty, as can Commit and Author - tolerate this (#15835) 2021-05-12 01:11:42 -04:00
commit_test.go Fix modified files list in webhooks when there is a space (#16288) 2021-07-02 21:23:37 +02:00
diff.go Support unprotected file patterns (#16395) 2021-09-11 16:21:17 +02:00
diff_test.go
error.go Fix 500 Error with branch and tag sharing the same name #15592 (#16040) 2021-06-23 17:08:26 -04:00
git.go Disable core.protectNTFS (#17300) 2021-10-13 14:20:11 -04:00
git_test.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
hook.go refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
last_commit_cache.go Defer Last Commit Info (#16467) 2021-10-08 15:08:22 +02:00
last_commit_cache_gogit.go Defer Last Commit Info (#16467) 2021-10-08 15:08:22 +02:00
last_commit_cache_nogogit.go Defer Last Commit Info (#16467) 2021-10-08 15:08:22 +02:00
lfs.go Let package git depend on setting but not opposite (#15241) 2021-06-26 13:28:55 +02:00
log_name_status.go Check for context exceeded in WalkGitLog (#17319) 2021-10-15 19:41:34 +01:00
notes.go
notes_gogit.go Defer Last Commit Info (#16467) 2021-10-08 15:08:22 +02:00
notes_nogogit.go Defer Last Commit Info (#16467) 2021-10-08 15:08:22 +02:00
notes_test.go Change the implementation of the go-git version of GetNote to mirror the non go-git version when passed a non-existent commit (#16658) 2021-08-09 16:24:34 +01:00
parse_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
parse_gogit_test.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
parse_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
parse_nogogit_test.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
README.md
ref.go
remote.go Add push to remote mirror repository (#15157) 2021-06-14 19:20:43 +02:00
repo.go Fix bundle creation (#17079) 2021-09-26 00:29:25 +03:00
repo_archive.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_attribute.go Ignore Sync errors on pipes when doing CheckAttributeReader.CheckPath, fix the hang of git cat-file (#17096) 2021-09-20 20:46:51 +01:00
repo_attribute_test.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 2021-09-09 21:13:36 +01:00
repo_base_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_base_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_blame.go
repo_blob.go
repo_blob_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_blob_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_blob_test.go refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
repo_branch.go Add a simple way to rename branch like gh (#15870) 2021-10-08 19:03:04 +02:00
repo_branch_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_branch_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_branch_test.go
repo_commit.go refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
repo_commit_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_commit_nogogit.go refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
repo_commit_test.go Replace list.List with slices (#16311) 2021-08-09 14:08:51 -04:00
repo_commitgraph_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_compare.go Add buttons to allow loading of incomplete diffs (#16829) 2021-10-15 17:05:33 +01:00
repo_compare_test.go refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
repo_gpg.go
repo_hook.go
repo_index.go refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
repo_language_stats.go
repo_language_stats_gogit.go refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
repo_language_stats_nogogit.go refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
repo_language_stats_test.go Ignore Sync errors on pipes when doing CheckAttributeReader.CheckPath, fix the hang of git cat-file (#17096) 2021-09-20 20:46:51 +01:00
repo_object.go
repo_ref.go
repo_ref_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_ref_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_ref_test.go
repo_stats.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
repo_stats_test.go
repo_tag.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
repo_tag_gogit.go Add skip and limit to git.GetTags (#16897) 2021-09-10 19:30:37 +02:00
repo_tag_nogogit.go Add skip and limit to git.GetTags (#16897) 2021-09-10 19:30:37 +02:00
repo_tag_test.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
repo_test.go Tests should use test files (#15801) 2021-05-09 17:20:33 +02:00
repo_tree.go
repo_tree_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_tree_nogogit.go refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
sha1.go
sha1_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
sha1_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
signature.go
signature_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
signature_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
submodule.go Fix some lints (#17337) 2021-10-17 20:47:12 +01:00
submodule_test.go
tag.go Tagger can be empty, as can Commit and Author - tolerate this (#15835) 2021-05-12 01:11:42 -04:00
tag_test.go
tree.go Add TestPrepareWikiFileName (#16487) 2021-07-20 15:16:20 +02:00
tree_blob.go
tree_blob_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_blob_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_entry.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
tree_entry_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_entry_mode.go
tree_entry_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_entry_test.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
utils.go Multiple Escaping Improvements (#17551) 2021-11-16 18:18:25 +00:00
utils_test.go

README.md

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.