forgejo/routers/api/v1/repo
Otto Richter (fnetX) 3362620ee3
Fix api error message if fork exists (#24487)
On the @Forgejo instance of Codeberg, we discovered that forking a repo
which is already forked now returns a 500 Internal Server Error, which
is unexpected. This is an attempt at fixing this.

The error message in the log:
~~~
2023/05/02 08:36:30 .../api/v1/repo/fork.go:147:CreateFork() [E]
[6450cb8e-113] ForkRepository: repository is already forked by user
[uname: ...., repo path: .../..., fork path: .../...]
~~~

The service that is used for forking returns a custom error message
which is not checked against.

About the order of options:
The case that the fork already exists should be more common, followed by
the case that a repo with the same name already exists for other
reasons. The case that the global repo limit is hit is probably not the
likeliest.

Co-authored-by: Otto Richter <otto@codeberg.org>
Co-authored-by: Giteabot <teabot@gitea.io>
2023-05-02 20:26:38 -04:00
..
blob.go
branch.go
collaborators.go
commits.go Add ability to specify '--not' from GetAllCommits (#24409) 2023-04-29 08:34:14 -04:00
file.go
fork.go Fix api error message if fork exists (#24487) 2023-05-02 20:26:38 -04:00
git_hook.go
git_ref.go
hook.go
hook_test.go
issue.go
issue_attachment.go
issue_comment.go Fix issue attachment handling (#24202) 2023-04-20 02:39:44 -04:00
issue_comment_attachment.go
issue_dependency.go
issue_label.go
issue_reaction.go
issue_stopwatch.go
issue_subscription.go
issue_tracked_time.go
key.go
label.go
language.go
main_test.go
migrate.go
milestone.go
mirror.go
notes.go
patch.go
pull.go
pull_review.go
release.go
release_attachment.go
release_tags.go
repo.go
repo_test.go
star.go
status.go
subscriber.go
tag.go
teams.go
topic.go
transfer.go
tree.go
wiki.go Make wiki title supports dashes and improve wiki name related features (#24143) 2023-04-19 13:50:10 -04:00