542cec98f8
Follow #22568 * Remove unnecessary ToTrustedCmdArgs calls * the FAQ in #22678 * Quote: When using ToTrustedCmdArgs, the code will be very complex (see the changes for examples). Then developers and reviewers can know that something might be unreasonable. * The `signArg` couldn't be empty, it's either `-S{keyID}` or `--no-gpg-sign`. * Use `signKeyID` instead, add comment "empty for no-sign, non-empty to sign" * 5-line code could be extracted to a common `NewGitCommandCommit()` to handle the `signKeyID`, but I think it's not a must, current code is clear enough. |
||
---|---|---|
.. | ||
check.go | ||
check_test.go | ||
comment.go | ||
commit_status.go | ||
edits.go | ||
lfs.go | ||
main_test.go | ||
merge.go | ||
merge_merge.go | ||
merge_prepare.go | ||
merge_rebase.go | ||
merge_squash.go | ||
merge_test.go | ||
patch.go | ||
patch_unmerged.go | ||
pull.go | ||
pull_test.go | ||
review.go | ||
temp_repo.go | ||
update.go | ||
update_rebase.go |