patchii/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
forgejo/cmd
History
emilylange 230a677c74
test(dump): don't depend on directory listing order 
cmd/dump.go uses os.Readdir to list the directory.

This is fine on its own, but TestAddRecursiveExclude in cmd/dump_test.go
depends on the order of the directory listing, which is where the issue
lays.

Directory listings using os.Readdir (lstat) don't actually guarantee an
order. They can differ due to a number of factors. Most notably the OS,
file system and settings.

As such, the test should not check the /order of the files/ added to the
archive, but instead simply check whether the archive /contains/ them.

So this is precisely what this commit does.

Note that only TestAddRecursiveExclude/File_inside_directory/No_exclude
has been observed to fail due to this, but all TestAddRecursiveExclude
subtests have been updated for consistency.
2024-06-17 17:54:59 +02:00
..
forgejo fix(f3): do not run the F3 CLI if F3 is disabled 2024-06-16 13:33:33 +02:00
actions.go [BRANDING] cosmetic s/Gitea/Forgejo/ in logs, messages, etc. 2024-02-05 16:02:14 +01:00
admin.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
admin_auth.go chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621) 2024-04-28 15:39:00 +02:00
admin_auth_ldap.go
admin_auth_ldap_test.go
admin_auth_oauth.go chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621) 2024-04-28 15:39:00 +02:00
admin_auth_stmp.go chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621) 2024-04-28 15:39:00 +02:00
admin_regenerate.go Revert "[BUG] Initalize Git for hook regeneration" 2024-02-26 22:30:25 +01:00
admin_user.go
admin_user_change_password.go Improve "must-change-password" logic and document (#30472) 2024-04-21 11:29:08 +02:00
admin_user_create.go fix(cli): admin user create first user never require a password change 2024-04-24 15:43:27 +02:00
admin_user_delete.go chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621) 2024-04-28 15:39:00 +02:00
admin_user_generate_access_token.go chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621) 2024-04-28 15:39:00 +02:00
admin_user_list.go
admin_user_must_change_password.go
cert.go [BRANDING] cosmetic s/Gitea/Forgejo/ in logs, messages, etc. 2024-02-05 16:02:14 +01:00
cmd.go
docs.go [BRANDING] cosmetic s/Gitea/Forgejo/ in logs, messages, etc. 2024-02-05 16:02:14 +01:00
doctor.go [BRANDING] cosmetic s/Gitea/Forgejo/ in logs, messages, etc. 2024-02-05 16:02:14 +01:00
doctor_convert.go [CHORE] Remove Microsoft SQL Server Support 2024-04-05 23:37:36 +02:00
doctor_test.go Move doctor package from modules to services (#28856) 2024-01-20 10:07:31 +08:00
dump.go [CHORE] Remove Microsoft SQL Server Support 2024-04-05 23:37:36 +02:00
dump_repo.go
dump_test.go test(dump): don't depend on directory listing order 2024-06-17 17:54:59 +02:00
embedded.go chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621) 2024-04-28 15:39:00 +02:00
generate.go [GITEA] Refactor generation of JWT secret 2024-02-05 16:54:44 +01:00
hook.go fix: hook post-receive for sha256 repos 2024-05-15 16:43:16 +02:00
hook_test.go Add unit tests for update git hook 2024-04-06 17:01:33 +02:00
keys.go Refactor cmd setup and remove deadcode (#29313) 2024-02-26 22:30:25 +01:00
mailer.go Return responseText instead of string in some functions (#28836) 2024-01-19 10:45:23 +08:00
main.go feat(F3): CLI: f3 mirror to convert to/from Forgejo 2024-06-14 12:52:12 +02:00
main_test.go
manager.go [BRANDING] cosmetic s/Gitea/Forgejo/ in logs, messages, etc. 2024-02-05 16:02:14 +01:00
manager_logging.go chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621) 2024-04-28 15:39:00 +02:00
migrate.go
migrate_storage.go tests(cmd): add coverage for migrateActionsArtifacts 2024-06-09 16:02:31 +02:00
migrate_storage_test.go tests(cmd): add coverage for migrateActionsArtifacts 2024-06-09 16:02:31 +02:00
restore_repo.go
serv.go [CHORE] Remove println 2024-04-12 13:36:31 +02:00
web.go Clean up log messages (#30313) 2024-04-15 20:01:35 +02:00
web_acme.go
web_graceful.go
web_https.go