mrsdizzie ca46385637 Clean up various use of escape/unescape functions for URL generation (#6334) ... * Use PathUnescape instead of QueryUnescape when working with branch names Currently branch names with a '+' fail in certain situations because QueryUnescape replaces the + character with a blank space. Using PathUnescape should be better since it is defined as: // PathUnescape is identical to QueryUnescape except that it does not // unescape '+' to ' ' (space). Fixes #6333 * Change error to match new function name * Add new util function PathEscapeSegments This function simply runs PathEscape on each segment of a path without touching the forward slash itself. We want to use this instead of PathEscape/QueryEscape in most cases because a forward slash is a valid name for a branch etc... and we don't want that escaped in a URL. Putting this in new file url.go and also moving a couple similar functions into that file as well. * Use EscapePathSegments where appropriate Replace various uses of EscapePath/EscapeQuery with new EscapePathSegments. Also remove uncessary uses of various escape/unescape functions when the text had already been escaped or was not escaped. * Reformat comment to make drone build happy * Remove no longer used url library * Requested code changes		2019-03-18 10:00:23 -04:00
..
activity.go
attachment.go
branch.go
commit.go
download.go
editor.go
editor_test.go
http.go
issue.go
issue_dependency.go
issue_label.go
issue_label_test.go
issue_lock.go
issue_stopwatch.go
issue_timetrack.go
issue_watch.go
main_test.go
middlewares.go
milestone.go
pull.go
pull_review.go
release.go
release_test.go
repo.go
search.go
setting.go
setting_protected_branch.go
settings_test.go
topic.go
view.go
webhook.go	Slack webhook channel name cannot be empty or just contain an hashtag (#4786)	2018-09-10 10:31:08 -04:00
wiki.go
wiki_test.go