flashii/misuzu
flashii/misuzu
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Convert audit log strings to constants.

Browse source
This commit is contained in:
flash 2018-12-15 19:46:48 +01:00
parent 84948121bc
commit 00a6e7ff9f
4 changed files with 40 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
public/auth.php
View file

@ -109,7 +109,7 @@ switch ($authMode) {
}
if (user_password_set($resetUser['user_id'], $authPassword['new'])) {
audit_log('PASSWORD_RESET', $resetUser['user_id']);
audit_log(MSZ_AUDIT_PASSWORD_RESET, $resetUser['user_id']);
} else {
throw new UnexpectedValueException('Password reset failed.');
}

16
public/manage/changelog.php
View file

@ -111,11 +111,11 @@ switch ($_GET['v'] ?? null) {
if ($changeId < 1) {
$changeId = db_last_insert_id();
audit_log('CHANGELOG_ENTRY_CREATE', user_session_current('user_id', 0), [$changeId]);
audit_log(MSZ_AUDIT_CHANGELOG_ENTRY_CREATE, user_session_current('user_id', 0), [$changeId]);
header('Location: ?v=change&c=' . $changeId);
return;
} else {
audit_log('CHANGELOG_ENTRY_EDIT', user_session_current('user_id', 0), [$changeId]);
audit_log(MSZ_AUDIT_CHANGELOG_ENTRY_EDIT, user_session_current('user_id', 0), [$changeId]);
}
}
@ -125,7 +125,7 @@ switch ($_GET['v'] ?? null) {
$addTag->bindValue('tag_id', $_POST['add_tag']);
if ($addTag->execute()) {
audit_log('CHANGELOG_TAG_ADD', user_session_current('user_id', 0), [
audit_log(MSZ_AUDIT_CHANGELOG_TAG_ADD, user_session_current('user_id', 0), [
$changeId,
$_POST['add_tag']
]);
@ -142,7 +142,7 @@ switch ($_GET['v'] ?? null) {
$removeTag->bindValue('tag_id', $_POST['remove_tag']);
if ($removeTag->execute()) {
audit_log('CHANGELOG_TAG_REMOVE', user_session_current('user_id', 0), [
audit_log(MSZ_AUDIT_CHANGELOG_TAG_REMOVE, user_session_current('user_id', 0), [
$changeId,
$_POST['remove_tag']
]);
@ -286,11 +286,11 @@ switch ($_GET['v'] ?? null) {
if ($tagId < 1) {
$tagId = db_last_insert_id();
audit_log('CHANGELOG_TAG_EDIT', user_session_current('user_id', 0), [$tagId]);
audit_log(MSZ_AUDIT_CHANGELOG_TAG_EDIT, user_session_current('user_id', 0), [$tagId]);
header('Location: ?v=tag&t=' . $tagId);
return;
} else {
audit_log('CHANGELOG_TAG_CREATE', user_session_current('user_id', 0), [$tagId]);
audit_log(MSZ_AUDIT_CHANGELOG_TAG_CREATE, user_session_current('user_id', 0), [$tagId]);
}
}
}
@ -360,11 +360,11 @@ switch ($_GET['v'] ?? null) {
if ($actionId < 1) {
$actionId = db_last_insert_id();
audit_log('CHANGELOG_ACTION_CREATE', user_session_current('user_id', 0), [$actionId]);
audit_log(MSZ_AUDIT_CHANGELOG_ACTION_CREATE, user_session_current('user_id', 0), [$actionId]);
header('Location: ?v=action&a=' . $actionId);
return;
} else {
audit_log('CHANGELOG_ACTION_EDIT', user_session_current('user_id', 0), [$actionId]);
audit_log(MSZ_AUDIT_CHANGELOG_ACTION_EDIT, user_session_current('user_id', 0), [$actionId]);
}
}
}

8
public/settings.php
View file

@ -35,14 +35,14 @@ if ($_SERVER['REQUEST_METHOD'] === 'POST') {
}
user_session_delete($session['session_id']);
audit_log('PERSONAL_SESSION_DESTROY', user_session_current('user_id'), [
audit_log(MSZ_AUDIT_PERSONAL_SESSION_DESTROY, user_session_current('user_id'), [
$session['session_id'],
]);
}
} elseif ($_POST['session'] === 'all') {
$currentSessionKilled = true;
user_session_purge_all(user_session_current('user_id'));
audit_log('PERSONAL_SESSION_DESTROY_ALL', user_session_current('user_id'));
audit_log(MSZ_AUDIT_PERSONAL_SESSION_DESTROY_ALL, user_session_current('user_id'));
}
if ($currentSessionKilled) {
@ -105,7 +105,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'POST') {
}
} else {
user_email_set(user_session_current('user_id'), $_POST['email']['new']);
audit_log('PERSONAL_EMAIL_CHANGE', user_session_current('user_id'), [
audit_log(MSZ_AUDIT_PERSONAL_EMAIL_CHANGE, user_session_current('user_id'), [
$_POST['email']['new'],
]);
}
@ -123,7 +123,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'POST') {
$errors[] = 'The given passwords was too weak.';
} else {
user_password_set(user_session_current('user_id'), $_POST['password']['new']);
audit_log('PERSONAL_PASSWORD_CHANGE', user_session_current('user_id'));
audit_log(MSZ_AUDIT_PERSONAL_PASSWORD_CHANGE, user_session_current('user_id'));
}
}
}

40
src/audit_log.php
View file

@ -1,19 +1,33 @@
<?php
define('MSZ_AUDIT_PERSONAL_EMAIL_CHANGE', 'PERSONAL_EMAIL_CHANGE');
define('MSZ_AUDIT_PERSONAL_PASSWORD_CHANGE', 'PERSONAL_PASSWORD_CHANGE');
define('MSZ_AUDIT_PERSONAL_SESSION_DESTROY', 'PERSONAL_SESSION_DESTROY');
define('MSZ_AUDIT_PERSONAL_SESSION_DESTROY_ALL', 'PERSONAL_SESSION_DESTROY_ALL');
define('MSZ_AUDIT_PASSWORD_RESET', 'PASSWORD_RESET');
define('MSZ_AUDIT_CHANGELOG_ENTRY_CREATE', 'CHANGELOG_ENTRY_CREATE');
define('MSZ_AUDIT_CHANGELOG_ENTRY_EDIT', 'CHANGELOG_ENTRY_EDIT');
define('MSZ_AUDIT_CHANGELOG_TAG_ADD', 'CHANGELOG_TAG_ADD');
define('MSZ_AUDIT_CHANGELOG_TAG_REMOVE', 'CHANGELOG_TAG_REMOVE');
define('MSZ_AUDIT_CHANGELOG_TAG_CREATE', 'CHANGELOG_TAG_CREATE');
define('MSZ_AUDIT_CHANGELOG_TAG_EDIT', 'CHANGELOG_TAG_EDIT');
define('MSZ_AUDIT_CHANGELOG_ACTION_CREATE', 'CHANGELOG_ACTION_CREATE');
define('MSZ_AUDIT_CHANGELOG_ACTION_EDIT', 'CHANGELOG_ACTION_EDIT');
// replace this with a localisation system
define('MSZ_AUDIT_LOG_STRINGS', [
'PERSONAL_EMAIL_CHANGE' => 'Changed e-mail address to %s.',
'PERSONAL_PASSWORD_CHANGE' => 'Changed account password.',
'PERSONAL_SESSION_DESTROY' => 'Ended session #%d.',
'PERSONAL_SESSION_DESTROY_ALL' => 'Ended all personal sessions.',
'PASSWORD_RESET' => 'Successfully used the password reset form to change password.',
'CHANGELOG_ENTRY_CREATE' => 'Created a new changelog entry #%d.',
'CHANGELOG_ENTRY_EDIT' => 'Edited changelog entry #%d.',
'CHANGELOG_TAG_ADD' => 'Added tag #%2$d to changelog entry #%1$d.',
'CHANGELOG_TAG_REMOVE' => 'Removed tag #%2$d from changelog entry #%1$d.',
'CHANGELOG_TAG_CREATE' => 'Created new changelog tag #%d.',
'CHANGELOG_TAG_EDIT' => 'Edited changelog tag #%d.',
'CHANGELOG_ACTION_CREATE' => 'Created new changelog action #%d.',
'CHANGELOG_ACTION_EDIT' => 'Edited changelog action #%d.',
MSZ_AUDIT_PERSONAL_EMAIL_CHANGE => 'Changed e-mail address to %s.',
MSZ_AUDIT_PERSONAL_PASSWORD_CHANGE => 'Changed account password.',
MSZ_AUDIT_PERSONAL_SESSION_DESTROY => 'Ended session #%d.',
MSZ_AUDIT_PERSONAL_SESSION_DESTROY_ALL => 'Ended all personal sessions.',
MSZ_AUDIT_PASSWORD_RESET => 'Successfully used the password reset form to change password.',
MSZ_AUDIT_CHANGELOG_ENTRY_CREATE => 'Created a new changelog entry #%d.',
MSZ_AUDIT_CHANGELOG_ENTRY_EDIT => 'Edited changelog entry #%d.',
MSZ_AUDIT_CHANGELOG_TAG_ADD => 'Added tag #%2$d to changelog entry #%1$d.',
MSZ_AUDIT_CHANGELOG_TAG_REMOVE => 'Removed tag #%2$d from changelog entry #%1$d.',
MSZ_AUDIT_CHANGELOG_TAG_CREATE => 'Created new changelog tag #%d.',
MSZ_AUDIT_CHANGELOG_TAG_EDIT => 'Edited changelog tag #%d.',
MSZ_AUDIT_CHANGELOG_ACTION_CREATE => 'Created new changelog action #%d.',
MSZ_AUDIT_CHANGELOG_ACTION_EDIT => 'Edited changelog action #%d.',
]);
function audit_log(