- https://flash.moe
-
⚡ if it ain't broke, i'll break it
- Joined on
2021-07-02 -
-
Final set of requests before we should be good! Mostly Lua specific moments and one more style thingy.
in stringTable do should be in pairs(stringTable) do
Can you move this above lesbian (so basically where superLesbian is currently)? I want to keep config type thingies at the top, somehow didn't realise it wasn't there until at the top already until now.
Can you move this function below lesbian? Apparently declaration order matters for local functions, I wasn't aware of this either 😎
Just noticed an oversight here, probably happened when reducing it from its previous implementation, the return false is within the for loop and the function itself doesn't have an end
other than these last few nitpicks this looks good to me, i'll test it in a bit!
this feels extremely nitpicky on my part but this should have one less indent
also bump the version in sense.toml to 1.1.0 if you wana, since added functionality
Could you also remove this if and associated parameter? since its no longer being used without it
i think you'd have to use the ipairs iterator for that
for k,v in ipairs(englishNames) do , i'm not sure if that is the exact syntax though
wait no yeah you're absolutely right sorry i'm not sure what i was thinking, however you could still use the hashmap to keep the different specific distance values
using the review feature for the first time ever whoa hope i did alright
maybe it'd be nicer to have this be a dictionary that contains = so like
its fine to just leave this as an exact match since its a one off gag and not have to bother with the if statement in the array lookup function
following the comment on englishNames you could replace the superLesbian func entirely with a hashmap lookup, just something like